Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added qbittorrent sensor platform #18618

Merged
merged 24 commits into from
Nov 29, 2018

Conversation

eliseomartelli
Copy link
Contributor

@eliseomartelli eliseomartelli commented Nov 21, 2018

Description:

Added a sensor platform to retrieve data from the qBittorrent API.

Documentation PR home-assistant/home-assistant.io#7597

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: qbittorrent
    url: "http://192.168.0.xx:8080"
    username: <username>
    password: <password>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@frenck
Copy link
Member

frenck commented Nov 21, 2018

Could not find a matching PR targeting our documentation repository. Adding docs-missing label.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick comments.

homeassistant/components/sensor/qbittorrent.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/qbittorrent.py Outdated Show resolved Hide resolved
@eliseomartelli
Copy link
Contributor Author

@fabaff Applied your suggestions :)

homeassistant/components/sensor/qbittorrent.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/qbittorrent.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/qbittorrent.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/qbittorrent.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/qbittorrent.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/qbittorrent.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/qbittorrent.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/qbittorrent.py Outdated Show resolved Hide resolved
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @fabaff?

@ghost ghost assigned fabaff Nov 29, 2018
@fabaff fabaff merged commit 5c026b1 into home-assistant:dev Nov 29, 2018
@ghost ghost removed the in progress label Nov 29, 2018
@eliseomartelli eliseomartelli deleted the qbittorrent-sensor branch November 29, 2018 19:59
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants